Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cardano.Api -> Cardano.Api.Typed and HardForkBlock #1909

Merged
merged 87 commits into from
Jul 25, 2020
Merged

Cardano.Api -> Cardano.Api.Typed and HardForkBlock #1909

merged 87 commits into from
Jul 25, 2020

Conversation

rvl
Copy link
Contributor

@rvl rvl commented Jul 15, 2020 •
edited
Loading

Issue Number

Relates to #1870.

Overview

  • Updates cardano-node to latest master version.
  • Updates libraries to version from cardano-node master.
  • Cardano.Api → Cardano.Api.Typed changes.
  • Change ShelleyBlock → CardanoBlock sc in "Compatibility" module
  • Change ShelleyBlock → CardanoBlock sc in network module
  • Add in byron implementations of conversion functions for two-era mode.
  • Add CLI support for two-era mode.
  • Use LocalStateQuery to get the history Interpreter from the node.
  • Update shelley transaction layer to use new extended keys support in Cardano.Api.Typed.

Comments

  • Fix all the type errors in packages other than cardano-wallet-shelley.
  • Transaction layer works during shelley era
  • Transaction layer works during byron era
  • Manual testing against mainnet_candidate which is in byron era -- can sync and restore empty wallet
  • Manual testing against shelley_qa which is in shelley era -- can sync and restore empty wallet
  • Unit tests passing
  • Merge integration test cluster setup from Integration test cluster for Byron;Shelley #1924, and fix.

@rvl rvl added the ADDING FEATURE Mark a PR as adding a new feature, for auto-generated CHANGELOG label Jul 15, 2020
@rvl rvl self-assigned this Jul 15, 2020
@rvl rvl changed the title Rvl/1870/bump deps Cardano.Api -> Cardano.Api.Typed Jul 15, 2020
@rvl rvl mentioned this pull request Jul 15, 2020
Merged
1 task
@Anviking Anviking mentioned this pull request Jul 15, 2020
Closed
9 tasks
iohk-bors bot added a commit that referenced this pull request Jul 15, 2020
@iohk-bors @rvl
Merge #1910
c90fe65 
1910: Bump cardano-node to 1.15.1 tag r=rvl a=rvl

### Issue Number

Relates to #1870 / #1909.

### Overview

- Updates cardano-node, just the node, not the libraries to the latest tagged release.

### Comments

- [ ] Tests pass


Co-authored-by: Rodney Lorrimar <[email protected]>
@rvl rvl force-pushed the rvl/1870/bump-deps branch 2 times, most recently from 291e9db to 3b96a3b Compare July 16, 2020 04:36
@rvl rvl changed the title Cardano.Api -> Cardano.Api.Typed Cardano.Api -> Cardano.Api.Typed and HardForkBlock Jul 17, 2020
rvl added a commit that referenced this pull request Jul 18, 2020
@rvl
cardano-node: 1.15.1 -> 1.16.0
3f9e9ea 
This updates cardano-node and cardano-cli, but not the cardano
libraries, which will be taken care of in
#1909
rvl added a commit that referenced this pull request Jul 18, 2020
@rvl
cardano-node: 1.15.1 -> 1.16.0
6b1146a 
This updates cardano-node and cardano-cli, but not the cardano
libraries, which will be taken care of in
#1909
@rvl rvl mentioned this pull request Jul 18, 2020
Closed
@rvl rvl force-pushed the rvl/1870/bump-deps branch 3 times, most recently from d8c7ea2 to 4e403f7 Compare July 18, 2020 07:48
iohk-bors bot added a commit that referenced this pull request Jul 18, 2020
@iohk-bors @rvl
Merge #1925
48888cb 
1925: cardano-node: 1.15.1 -> 1.16.x (master branch) r=Anviking a=rvl

### Issue Number

Relates to #1920.

### Overview

This updates cardano-node and cardano-cli from 1.15.1 to ~1.16.0~ [e28c1d3](IntersectMBO/cardano-node@e28c1d3), but not the cardano libraries, which will be taken care of in #1909.


Co-authored-by: Rodney Lorrimar <[email protected]>
@rvl rvl force-pushed the rvl/1870/bump-deps branch 3 times, most recently from 4a06270 to e38582b Compare July 19, 2020 14:05
@Anviking Anviking self-requested a review July 19, 2020 17:37
@rvl rvl mentioned this pull request Jul 20, 2020
Closed
@KtorZ
Copy link
Member

KtorZ commented Jul 21, 2020

Transaction layer works during byron era

We can tackle that in a second time..... Or not. With the time constraints we have, there will likely be very little time between the release and the hard-fork. So we may as well leave it as it is.

paweljakubas and others added 3 commits July 25, 2020 12:13
@paweljakubas @KtorZ
make feeOpt dependent on minimum utxo
7ab39b1
@KtorZ
add non-null dust & property reflecting it for 'rebalanceSelection'
dc9e571 
  This fails now, since 'rebalanceSelection' completely disregard any
  form of dust threshold.
@KtorZ
acknowledge dust threshold in fee balancing
ec9ea5d 
  I greatly simplified the function as well, it probably handles slightly worse some edge-cases but it's probably for the best in terms of maintenance burden.
@KtorZ
Copy link
Member

KtorZ commented Jul 25, 2020

bors r+

please.

iohk-bors bot added a commit that referenced this pull request Jul 25, 2020
@iohk-bors @rvl @Anviking
Merge #1909
234782a 
1909: Cardano.Api -> Cardano.Api.Typed and HardForkBlock r=KtorZ a=rvl

### Issue Number

Relates to #1870.

### Overview

- Updates cardano-node to latest master version.
- Updates libraries to version from cardano-node master.
- Cardano.Api → Cardano.Api.Typed changes.
- Change `ShelleyBlock` → `CardanoBlock sc` in "Compatibility" module
- Change `ShelleyBlock` → `CardanoBlock sc` in network module
- Add in byron implementations of conversion functions for two-era mode.
- Add CLI support for two-era mode.
- Use LocalStateQuery to get the history Interpreter from the node.
- Update shelley transaction layer to use new extended keys support in Cardano.Api.Typed.

### Comments

- [x] Fix all the type errors in packages other than cardano-wallet-shelley.
- [x] Transaction layer works during shelley era
- [ ] Transaction layer works during byron era
- [x] Manual testing against [mainnet_candidate](https://hydra.iohk.io/job/Cardano/iohk-nix/cardano-deployment/latest/download/1/index.html) which is in byron era -- can sync and restore empty wallet
- [x] Manual testing against [shelley_qa](https://hydra.iohk.io/job/Cardano/iohk-nix/cardano-deployment/latest/download/1/index.html) which is in shelley era -- can sync and restore empty wallet
- [ ] Unit tests passing
- [x] Merge integration test cluster setup from #1924, and fix.


Co-authored-by: Rodney Lorrimar <[email protected]>
Co-authored-by: Johannes Lund <[email protected]>
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Jul 25, 2020

Build failed

@KtorZ
Copy link
Member

KtorZ commented Jul 25, 2020

bors retry

iohk-bors bot added a commit that referenced this pull request Jul 25, 2020
@iohk-bors @rvl @Anviking
Merge #1909
e74a16f 
1909: Cardano.Api -> Cardano.Api.Typed and HardForkBlock r=KtorZ a=rvl

### Issue Number

Relates to #1870.

### Overview

- Updates cardano-node to latest master version.
- Updates libraries to version from cardano-node master.
- Cardano.Api → Cardano.Api.Typed changes.
- Change `ShelleyBlock` → `CardanoBlock sc` in "Compatibility" module
- Change `ShelleyBlock` → `CardanoBlock sc` in network module
- Add in byron implementations of conversion functions for two-era mode.
- Add CLI support for two-era mode.
- Use LocalStateQuery to get the history Interpreter from the node.
- Update shelley transaction layer to use new extended keys support in Cardano.Api.Typed.

### Comments

- [x] Fix all the type errors in packages other than cardano-wallet-shelley.
- [x] Transaction layer works during shelley era
- [ ] Transaction layer works during byron era
- [x] Manual testing against [mainnet_candidate](https://hydra.iohk.io/job/Cardano/iohk-nix/cardano-deployment/latest/download/1/index.html) which is in byron era -- can sync and restore empty wallet
- [x] Manual testing against [shelley_qa](https://hydra.iohk.io/job/Cardano/iohk-nix/cardano-deployment/latest/download/1/index.html) which is in shelley era -- can sync and restore empty wallet
- [ ] Unit tests passing
- [x] Merge integration test cluster setup from #1924, and fix.


Co-authored-by: Rodney Lorrimar <[email protected]>
Co-authored-by: Johannes Lund <[email protected]>
@piotr-iohk piotr-iohk mentioned this pull request Jul 25, 2020
Closed
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Jul 25, 2020

Build failed

KtorZ and others added 3 commits July 25, 2020 16:18
@KtorZ
revert refactor on 'rebalanceSelection' and coalesce dust AFTER rebal…
70235f0 
…ancing

  What we loose from this might be exact balancing in some cases (when the transaction is exactly balanced but coalescing dust may remove one or more change output and change the fee).
  So we might hit problems with some edge-cases on Jörmungandr but things should be fine on cardano-node where we might occasionally pay a little bit more than necessary...
@KtorZ
Merge pull request #1947 from input-output-hk/paweljakubas/proper-tre…
c4e978a 
…atment-of-dusting-threshold

make feeOpt dependent on minimum utxo
@KtorZ
adjust pool pool retirement configuration and retire first pool when …
bca0b7a 
…it's safe

  Retiring at epoch 1 causes some race condition with the cluster setup.
  Indeed, we now know to wait for the hard fork to begin and it
  sometimes happen that it's already too late to submit the certificate
  for a retirement in epoch 1. Therefore, retirement now happens a bit
  later. Also, I've bumped the retirement at epoch '1_000' to '100_000'
  because we are actually reaching epoch 1_000 pretty early in the test
  suite and even up to 10k epochs!
@KtorZ
Copy link
Member

KtorZ commented Jul 25, 2020

bors r+

iohk-bors bot added a commit that referenced this pull request Jul 25, 2020
@iohk-bors @rvl @Anviking
Merge #1909
f5b1458 
1909: Cardano.Api -> Cardano.Api.Typed and HardForkBlock r=KtorZ a=rvl

### Issue Number

Relates to #1870.

### Overview

- Updates cardano-node to latest master version.
- Updates libraries to version from cardano-node master.
- Cardano.Api → Cardano.Api.Typed changes.
- Change `ShelleyBlock` → `CardanoBlock sc` in "Compatibility" module
- Change `ShelleyBlock` → `CardanoBlock sc` in network module
- Add in byron implementations of conversion functions for two-era mode.
- Add CLI support for two-era mode.
- Use LocalStateQuery to get the history Interpreter from the node.
- Update shelley transaction layer to use new extended keys support in Cardano.Api.Typed.

### Comments

- [x] Fix all the type errors in packages other than cardano-wallet-shelley.
- [x] Transaction layer works during shelley era
- [ ] Transaction layer works during byron era
- [x] Manual testing against [mainnet_candidate](https://hydra.iohk.io/job/Cardano/iohk-nix/cardano-deployment/latest/download/1/index.html) which is in byron era -- can sync and restore empty wallet
- [x] Manual testing against [shelley_qa](https://hydra.iohk.io/job/Cardano/iohk-nix/cardano-deployment/latest/download/1/index.html) which is in shelley era -- can sync and restore empty wallet
- [ ] Unit tests passing
- [x] Merge integration test cluster setup from #1924, and fix.


Co-authored-by: Rodney Lorrimar <[email protected]>
Co-authored-by: Johannes Lund <[email protected]>
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Jul 25, 2020

Build failed

@KtorZ
Copy link
Member

KtorZ commented Jul 25, 2020

bors r+

iohk-bors bot added a commit that referenced this pull request Jul 25, 2020
@iohk-bors @rvl @Anviking
Merge #1909
a3e644e 
1909: Cardano.Api -> Cardano.Api.Typed and HardForkBlock r=KtorZ a=rvl

### Issue Number

Relates to #1870.

### Overview

- Updates cardano-node to latest master version.
- Updates libraries to version from cardano-node master.
- Cardano.Api → Cardano.Api.Typed changes.
- Change `ShelleyBlock` → `CardanoBlock sc` in "Compatibility" module
- Change `ShelleyBlock` → `CardanoBlock sc` in network module
- Add in byron implementations of conversion functions for two-era mode.
- Add CLI support for two-era mode.
- Use LocalStateQuery to get the history Interpreter from the node.
- Update shelley transaction layer to use new extended keys support in Cardano.Api.Typed.

### Comments

- [x] Fix all the type errors in packages other than cardano-wallet-shelley.
- [x] Transaction layer works during shelley era
- [ ] Transaction layer works during byron era
- [x] Manual testing against [mainnet_candidate](https://hydra.iohk.io/job/Cardano/iohk-nix/cardano-deployment/latest/download/1/index.html) which is in byron era -- can sync and restore empty wallet
- [x] Manual testing against [shelley_qa](https://hydra.iohk.io/job/Cardano/iohk-nix/cardano-deployment/latest/download/1/index.html) which is in shelley era -- can sync and restore empty wallet
- [ ] Unit tests passing
- [x] Merge integration test cluster setup from #1924, and fix.


Co-authored-by: Rodney Lorrimar <[email protected]>
Co-authored-by: Johannes Lund <[email protected]>
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Jul 25, 2020 •
edited by KtorZ
Loading

Build failed

Seen once already and quite flaky. Will investigate later outside of this PR ☝️

@KtorZ KtorZ merged commit f75b926 into master Jul 25, 2020
@KtorZ KtorZ deleted the rvl/1870/bump-deps branch July 25, 2020 17:08
@AlexIOHK
Copy link

🎉

@andy521md
Copy link

andy521md commented Jul 25, 2020 via email

@rvl rvl mentioned this pull request Jul 26, 2020
Closed
iohk-bors bot added a commit that referenced this pull request Jul 27, 2020
@iohk-bors @paweljakubas
Merge #1932
b2def3b 
1932: Hardfork countdown support r=KtorZ a=paweljakubas

# Issue Number

<!-- Put here a reference to the issue this PR relates to and which requirements it tackles -->
#1917 

# Overview

<!-- Detail in a few bullet points the work accomplished in this PR -->

- [x] I have extended `ApiNetworkParameters` 
- [x] I have updated swagger accordingly
- [x] I have updated core `TypeSpec`
- [x] I have extended `NetworkParameters`
- [x] I have extended DB schema and addressed DB migrations
- [x] I have used `QueryAnytimeShelley EraStart` from `CardanoQuery` to get value
- [x] I have tested the above


# Comments

<!-- Additional comments or screenshots to attach if any -->
To move forward I need #1909 to be merged. 
As,
```
QueryAnyTimeShelley EraStart :: Query CardanoBlock
```
<!-- 
Don't forget to:

 ✓ Self-review your changes to make sure nothing unexpected slipped through
 ✓ Assign yourself to the PR
 ✓ Assign one or several reviewer(s)
 ✓ Once created, link this PR to its corresponding ticket
 ✓ Assign the PR to a corresponding milestone
 ✓ Acknowledge any changes required to the Wiki
-->


Co-authored-by: Pawel Jakubas <[email protected]>
This was referenced Jul 27, 2020
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KtorZ KtorZ KtorZ approved these changes

@Anviking Anviking Awaiting requested review from Anviking

Assignees

@rvl rvl

Labels
ADDING FEATURE Mark a PR as adding a new feature, for auto-generated CHANGELOG
Projects
None yet
Milestone
(ADP-356) Integration with Hard Fork ...
Development

Successfully merging this pull request may close these issues.
6 participants
@rvl @KtorZ @AlexIOHK @andy521md @Anviking @paweljakubas